-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add layer specific disclaimers #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the implementation in general but I have two comments, one is a nit pick and the other might need looking at before we approve?
- Could the bubble appear more centrally? I think the tour is in the middle but disclaimer is appearing at the top slightly over the header. This is not really an issue and happy to go with the majority if we are happy with the location.
- It appears that the bubble clears if you click anywhere outside the popup. This is fine for some but I think for the "Accept" example we will need to prevent that behaviour and force the user to actually click the button. This one I think we might want to investigate further.
Other than these suggestions, I think it looks good and happy to accept after we've discussed point 2 above.
…de modal or via keyboard
@paul-dorsetcouncil Good spot, that was supposed to not be dismissible by clicking outside. That is now fixed so you have to click the button to dismiss the modal. I've also moved the modal to the middle of the screen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you.
This PR adds optional disclaimers to individual layers.
Disclaimers appear the first time a user switches a layer on, and then reappears depending on the frequency. They are designed to warn users about terms of use or issues with a particular layer.
How it works
You create a 'disclaimer' in the management console, and then in the layer details page you choose the disclaimer you want.
Limitations
If a layer is already turned on (either through layer customisations or via a share link) the disclaimer will not trigger unless the user turns the layer off and back on. This is to prevent being potentially bombarded with disclaimers on first load. Imagine you have a welcome message, a tour, a cookie control banner and three layers turned on with separate disclaimers, the user would have to dismiss SIX separate overlays before the map could be used.
We could improve the logic to bundle any disclaimers into the welcome screen in one go, but this was deemed out of scope for initial implementation.