Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unnescessary Warning Messages #62

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

DogeDark
Copy link
Member

@DogeDark DogeDark commented Oct 26, 2024

Fixes hooks that incorrectly emit write-on-render warnings. Also fixes geolocation for 0.6.

@DogeDark DogeDark marked this pull request as ready for review October 28, 2024 04:03
@DogeDark DogeDark added the enhancement New feature or request label Oct 28, 2024
@DogeDark DogeDark requested a review from marc2332 October 28, 2024 04:03
Copy link
Collaborator

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@DogeDark DogeDark merged commit 03fcc96 into feat/dioxus-0.6 Nov 19, 2024
@DogeDark DogeDark deleted the allow-warnings branch November 19, 2024 23:01
DogeDark added a commit that referenced this pull request Dec 7, 2024
* feat: Dioxus 0.6 support

* bump dioxus-signals

* chore: clean up

* update: alpha 5

* Fix Unnescessary Warning Messages (#62)

* fix: allow window resize signal writes

* progress: interval

* fix: interval warnings, geolocation

* remove: warnings dep

* revision: change to 1 second

* 0.6.0-rc.0

* update: dioxus 0.6 & final touches

* fix: ci

* fix: clippy & issues

---------

Co-authored-by: Miles Murgaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants