Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rueidis tracing #3262

Merged
merged 5 commits into from
Mar 7, 2025
Merged

Support rueidis tracing #3262

merged 5 commits into from
Mar 7, 2025

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Mar 6, 2025

What does this PR do?

Add rueidis support by manual and orchestrion.

package main

import (
// ...
	__orchestrion_rueidistrace "gopkg.in/DataDog/dd-trace-go.v1/contrib/redis/rueidis"
// ...
	redis, err :=
		//line <generated>:1
		__orchestrion_rueidistrace.NewClient(
			//line ./main.go:53
			rueidis.ClientOption{
				InitAddress: []string{"redis:6379"},
			})
2025-03-06_15-44-14

Motivation

#2920, #3031

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@keisku keisku requested review from a team as code owners March 6, 2025 00:53
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 6, 2025
@keisku keisku changed the title contrib/riverqueue/river.v0: add suppor Support redis/rueidis tracing Mar 6, 2025
@keisku keisku marked this pull request as draft March 6, 2025 00:54
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 6, 2025

Datadog Report

Branch report: keisku/rueidis
Commit report: 77daae2
Test service: dd-trace-go

✅ 0 Failed, 5395 Passed, 73 Skipped, 2m 48.59s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 6, 2025

Benchmarks

Benchmark execution time: 2025-03-07 14:51:43

Comparing candidate commit dd5254d in PR branch keisku/rueidis with baseline commit 4800665 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 2 unstable metrics.

@keisku keisku changed the title Support redis/rueidis tracing Support rueidis tracing Mar 6, 2025
@keisku keisku marked this pull request as ready for review March 6, 2025 03:05
@keisku keisku requested a review from hannahkm March 7, 2025 02:39
@kakkoyun kakkoyun self-requested a review March 7, 2025 11:16
@hannahkm hannahkm enabled auto-merge (squash) March 7, 2025 14:23
@hannahkm hannahkm merged commit 25864e0 into main Mar 7, 2025
197 checks passed
@hannahkm hannahkm deleted the keisku/rueidis branch March 7, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants