Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize percent signs in help messages #507

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

DannyBen
Copy link
Owner

@DannyBen DannyBen commented Mar 20, 2024

This PR makes it so % symbols in help messages do not cause an implosion.

Before this PR, the following YAML failed.

name: cli

args:
- name: factor
  help: Provide % of change
- name: template
  help: Any string. Use %h or %H to specofy hostname

and the only way to make it work prior to this PR was to use %% instead of % - which then broke other uses of the string, such as generating man pages.

@DannyBen DannyBen merged commit 0549c60 into master Mar 20, 2024
9 checks passed
@DannyBen DannyBen deleted the add/percent-sign-sanitization branch March 20, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant