Minor corrections to phrasing/spelling. #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CorentinTh
previously approved these changes
Sep 3, 2023
|
Their is an issue with e2e test, can you please replace // in src/tools/password-strength-analyser/password-strength-analyser.e2e.spec.ts
// replace :
expect(crackDuration).toEqual('15,091 milleniums, 3 centurys');
// with :
expect(crackDuration).toEqual('15,091 millennia, 3 centuries');I can't edit your fork to do it myself :/ |
Sorry, I thought I had set it properly so you could edit as well, but I am new to pull requests. Just really love these tools so wanted to get involved. :) That change is now implemented! |
|
Kudos, SonarCloud Quality Gate passed!
|
|
No problem, thanks for the contribution 💪🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some small corrections to spellings and added correct plurals to the units in the password strength analyser.