Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ipv4-range-expander): calculate correct for ip addresses where the first octet is lower than 128 #405

Merged
merged 1 commit into from
May 15, 2023
Merged

fix(ipv4-range-expander): calculate correct for ip addresses where the first octet is lower than 128 #405

merged 1 commit into from
May 15, 2023

Conversation

cgoIT
Copy link
Contributor

@cgoIT cgoIT commented May 15, 2023

Fixes #399

@vercel
Copy link

vercel bot commented May 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview May 15, 2023 8:16am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cgoIT
Copy link
Contributor Author

cgoIT commented May 15, 2023

@CorentinTh I see a e2e test failing in the list converter. But only in Firefox. If I "reproduce" the test manually in Firefox on MacOS the result is fine. I'm not quite sure, but I think the test is failing since the refactoring of the input fields. Do you have any idea why the test fails in the playwright env but not manually in firefox? Or: Is the test failing on your local env? Maybe it's only a problem on my side/MacOS side?!

CorentinTh
CorentinTh approved these changes May 15, 2023
View reviewed changes
Copy link
Owner

@CorentinTh CorentinTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for fixing this issue 🙏🏻 💪🏻

@CorentinTh CorentinTh merged commit 8c92d56 into CorentinTh:main May 15, 2023
@CorentinTh
Copy link
Owner

@cgoIT yeah I've seen this flacky e2e test, I currently have no idea of what is causing this problem, I'll investigate if I have time 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CorentinTh CorentinTh CorentinTh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] IPv4 range expander returns bad values for networks smaller than 128.0.0.0
2 participants
@cgoIT @CorentinTh