feat(base64-string-converter): switch to encode and decode url safe #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CorentinTh
requested changes
May 14, 2023
src/utils/base64.ts
Outdated
| } | ||
|
|
||
| function base64ToText(str: string) { | ||
| if (!isValidBase64(str)) { | ||
| function base64ToText(str: string, urlSafe = false) { |
There was a problem hiding this comment.
I'm not really fan of magic boolean positionnal arguments, can you make this argument a config object please ?
Suggested change
| function base64ToText(str: string, urlSafe = false) { | |
| function base64ToText(str: string, { makeUrlSafe = false } : { makeUrlSafe?: boolean } = {}) { |
src/utils/base64.ts
Outdated
| @@ -22,12 +26,33 @@ function removePotentialDataAndMimePrefix(str: string) { | |||
| return str.replace(/^data:.*?;base64,/, ''); | |||
| } | |||
|
|
|||
| function isValidBase64(str: string) { | |||
| const cleanStr = removePotentialDataAndMimePrefix(str); | |||
| function isValidBase64(str: string, urlSafe = false) { | |||
There was a problem hiding this comment.
Same here
Suggested change
| function isValidBase64(str: string, urlSafe = false) { | |
| function isValidBase64(str: string, { decodeUrlSafe = false } : { decodeUrlSafe?: boolean } = {}) { |
…config object instead of boolean argument.
* main: refactor(ui): replaced some n-input with c-input-text chore(version): release 2023.05.14-77f2efc docs(changelog): update changelog for 2023.05.14-77f2efc refactor(ui): replaced some n-input with c-input-text ui-lib(new-component): added text input component in the c-lib ui-lib(button): size variants chore(issues): updated new tool request issue template # Conflicts: # src/tools/base64-string-converter/base64-string-converter.vue
…ditional refs for changes which interfere with validation rules
* main: fix(ipv4-converter): removed readonly on input
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #376