Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Japan Buildings sandcastle to use Japan Regional Terrain #12259

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

lukemckinstry
Copy link
Contributor

@lukemckinstry lukemckinstry commented Oct 22, 2024

Description

Updates Japan Buildings sandcastle to use Japan Regional Terrain

Issue number and link

https://github.com/CesiumGS/cesium-analytics/issues/1045

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @lukemckinstry!

✅ We can confirm we have a CLA on file for you.

@lukemckinstry lukemckinstry marked this pull request as ready for review October 22, 2024 14:34
Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjspace jjspace merged commit bb40a85 into main Oct 23, 2024
8 of 9 checks passed
@jjspace jjspace deleted the update-jp-terrain-sandcastle branch October 23, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants