Add regression tests for C++ sample programs #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed that one ... thanks for fixing! |
speth
force-pushed
the
cxx-sample-tests
branch
2 times, most recently
from
5b28d3c to
2c52e64
Compare
4 tasks
Add optional command line arguments to the sample so that it can produce stable output.
Changes to the blessed output file are a result of updates to atomic weights, and to fixes for how flow devices are updated (Cantera#886)
Remove the existing cxx_ex test which duplicates this sample. Differences in blessed output are a result of updates to atomic weights in dc96fb5.
We have plenty of tests of the equilibrium solver for ideal gas mixtures, and the reaction path diagram test doesn't make a very good C++ example.
This is the same method used for profile comparisons in the Python test suite. These comparisons are skipped (with a warning) if Numpy is not installed.
Codecov Report
@@ Coverage Diff @@
## main #883 +/- ##
==========================================
+ Coverage 70.43% 70.95% +0.51%
==========================================
Files 375 376 +1
Lines 45688 45889 +201
==========================================
+ Hits 32180 32560 +380
+ Misses 13508 13329 -179
Continue to review full report at Codecov.
|
|
Rebasing this after merging #886 allows the tests to run reliably on all platforms, so I think this is ready now. |
bryanwweber
requested changes
Jul 2, 2020
This provides the ability to organize data files included with Cantera and differentiate data which is useful for different purposes, e.g. sample data which is only meant to demonstrate capabilities and may not be physically meaningful. See Cantera/enhancements#22. Fixes Cantera#774
The samples are now built (and run) as part of `scons test`.
Correct. Just pushed a commit that removes these build steps. |
4 tasks
bryanwweber
approved these changes
Jul 3, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the tests added in #874 for the Fortran sample program, this PR adds tests for the C++ samples so they won't break without us knowing.
Changes proposed in this pull request
samplesfolder #774)air.yamland use of that file in thecombustor.cppsamplendimtonewTransportMgrwhich is currently ignored / unusedonedim.h(diagnosed thanks to running thebvpsample)Checklist
scons build&scons test) and unit tests address code coverageIf applicable, fill in the issue number this pull request is fixing
Fixes #774