-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ck2yaml argparse / yaml2k fixes #1616
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1616 +/- ##
==========================================
+ Coverage 72.66% 72.70% +0.03%
==========================================
Files 370 370
Lines 56255 56257 +2
Branches 20353 20351 -2
==========================================
+ Hits 40880 40903 +23
+ Misses 12372 12357 -15
+ Partials 3003 2997 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Adopt the same naming convention as used by other converter scripts.
Also, add quiet option to suppress output
27af5b9
to
870b5b9
Compare
21fb071
to
17a211b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny changes, thanks for taking this on!
252586d
to
78b187e
Compare
@bryanwweber ... thank you for the suggestions! |
Changes proposed in this pull request
ck2yaml
toargparse
in order to be consistent with other converter scriptssphinx-argparse
Solution.write_chemkin
bugsIf applicable, fill in the issue number this pull request is fixing
Closes #1611, partially addresses #1610
If applicable, provide an example illustrating new features this pull request is introducing
ck2yaml
now has the following help text (generated byargparse
)While not the main issue, this now works:
Checklist
scons build
&scons test
) and unit tests address code coverage