-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: Testing SCons 4.4.0 with multiple MSVC toolsets #1392
Conversation
b0d1923
to
13348db
Compare
@bryanwweber ... are you still working on this? Otherwise, I may take a stab ... |
@ischoegl I'm not, I don't have a Windows machine to do rapid iterations, but the changes here should be a good start to what you need: https://github.com/Cantera/cantera/pull/1392/files#diff-d78c5c377c03dd251edc72cdb0ae7d9986fa08361eb392187218f8c670c0bc4eR170 Edit to add: I was trying to test and make sure that we got the correct behavior for SCons <4.4.0 when the new Feel free to close this if/when you push up a new branch 😄 |
Superseded by #1404 |
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Closes #
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage