Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_pcm_archive.sh #153

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

taki-d
Copy link
Contributor

@taki-d taki-d commented Apr 4, 2022

select parts button in JLCPCB tools does not work.

  File "C:\Users\Takahiro\Documents\KiCad\6.0\3rdparty\plugins\com_github_bouni_kicad-jlcpcb-tools\plugin.py", line 22, in Run
    dialog = JLCPCBTools(None)
  File "C:\Users\Takahiro\Documents\KiCad\6.0\3rdparty\plugins\com_github_bouni_kicad-jlcpcb-tools\mainwindow.py", line 519, in __init__
    self.logger.info(f"kicad-jlcpcb-tools version {getVersion()}")
Message: 'kicad-jlcpcb-tools version 2022.04.01\n'

To solve this problem, update create_pcm_archives.sh to include settings.json to release

@Bouni Bouni merged commit 7eb516d into Bouni:main Apr 4, 2022
@Bouni Bouni added the bug Something isn't working label Apr 4, 2022
@Bouni
Copy link
Owner

Bouni commented Apr 4, 2022

Good catch, thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants