Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part Details dialog can't get input focus #165

Closed
alibenpeng opened this issue May 5, 2022 · 11 comments
Closed

Part Details dialog can't get input focus #165

alibenpeng opened this issue May 5, 2022 · 11 comments
Assignees
Labels
bug Something isn't working Linux Linux issue MacOS MacOS issue

Comments

@alibenpeng
Copy link

alibenpeng commented May 5, 2022

Describe the bug
The "Part Details" dialog opens but never gets the input focus until the parent ("Select Part"/"JLCPCB Library", in my case) window is closed.

To Reproduce
Steps to reproduce the behavior:

  1. Open JLCPCB Tools via toolbar button
  2. Select a part from the list
  3. Click on "Select Part"
  4. Find and select a part in "JLCPCB Library" window
  5. Click on "Part Details"
  6. The window opens but doesn't get focus, and can't even be closed again as long as the parent window is open. Also, typing Ctrl-W will close the parent window instead of the details dialog, which is quite annoying.

Expected behavior
The "Part Details" dialog should behave like any regular window.

KiCad Version

Version: 6.0.4-6f826c9f35~116~ubuntu20.04.1, release build
@livigni
Copy link

livigni commented May 8, 2022

same issue here

@Bouni Bouni added the bug Something isn't working label May 9, 2022
@Bouni
Copy link
Owner

Bouni commented May 9, 2022

I'll take a look at this as soon as possible ..

@ayourk
Copy link

ayourk commented May 17, 2022

As an aside to this, only when I close the "JLCPCB Library" window can I then click on the "Open Datasheet" button in the "JLPCB Part Details" window. Also, While the "JLCPCB Library" window is open, I cannot close any "JLPCB Part Details" windows until the "JLCPCB Library" window is closed. Maybe the parent window is becoming modal or something like that?

@Bouni
Copy link
Owner

Bouni commented May 17, 2022

@ayourk 🤔 maybe thats part off this issue. I need to look into this but first have to setup a linux machine including desktop which takes some time. Maybe I invest some more time and create a vm that I cna use for testing in the future ...

@Bouni
Copy link
Owner

Bouni commented Jun 7, 2022

I finally can reproduce it in a Ubuntu VM. The strange thig is that if the part details windo is opend from the main window, everything works as expected, but if I start it from the select part window the behaviour is as you've described it ....

@Bouni
Copy link
Owner

Bouni commented Jun 7, 2022

I tried now various things but its still a mystery to me whats going on here 😞
Maybe I'm able to figure it out in the log run but at the moment I have not the slightes idea what else to try ....

@Bouni Bouni added the Linux Linux issue label Jun 7, 2022
@ayourk
Copy link

ayourk commented Jun 7, 2022

Is there possibly some way you can forcibly make the main window call the part details window as a function call that the part window can use? Like some sort of event trigger?

@Bouni
Copy link
Owner

Bouni commented Jun 7, 2022

Oh that's actually a smart idea!
I'll test that tomorrow and let you know if that works!

@livigni
Copy link

livigni commented Jun 7, 2022

I have to say that I get same behaviour on macOs, so it shouldn't be a linux only thing.
The thing is happening when I'm searching for a component and then I select one option and click on part details. Then it is not possible to get focus on that window, as it appears below the Search one.
I believe that somehow the window got opened thinking it was called by the main Table view...

I explained myself terribly so I hope you could get some of what I meant :) Unfortunately I cannot send some screencast now as I am without external display and the plugin icon cannot be clicked (I think I will open another bug on this).

@ayourk
Copy link

ayourk commented Jun 7, 2022

MacOS is a Unix based OS these days, so not sure how "Windows" related it is.

computergeek1507 pushed a commit to computergeek1507/kicad-jlcpcb-tools that referenced this issue Jun 7, 2022
@Bouni Bouni added the MacOS MacOS issue label Jun 8, 2022
@Bouni
Copy link
Owner

Bouni commented Jun 8, 2022

This is solved in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Linux Linux issue MacOS MacOS issue
Projects
None yet
Development

No branches or pull requests

4 participants