[new feature] add vertex color morph target #16179
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
kmatzen
changed the title
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16179/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16179/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16179/merge#BCU1XR#0 |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16179/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16179/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16179/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
cc @alexchuber for the serializer change |
|
You have several webgpu tests failing though |
packages/dev/serializers/src/glTF/2.0/glTFMorphTargetsUtilities.ts
Outdated
Show resolved
Hide resolved
packages/dev/serializers/src/glTF/2.0/glTFMorphTargetsUtilities.ts
Outdated
Show resolved
Hide resolved
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
packages/dev/core/src/Materials/Node/Blocks/Vertex/morphTargetsBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/Materials/Node/Blocks/Vertex/morphTargetsBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/ShadersWGSL/ShadersInclude/morphTargetsVertexGlobalDeclaration.fx
Outdated
Show resolved
Hide resolved
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
@alexchuber , can we merge this? |
|
Yes, sorry for the delay. Thanks! |
see alpha testing changes: BabylonJS/Babylon.js#16144 see new color morph feature: BabylonJS/Babylon.js#16179
Any interest in having a morph target for vertex color? There are some glTF viewers out there that will actually display animated point clouds if you add morph targets for POSITION and COLOR_0. Two that I found are gestaltar and https://gltf-viewer.donmccurdy.com/. Looks like babylon.js doesn't wire in color as a morph target, so I grepped through the code and put it in.
Test plan
I only tried it with a test glb with animated point clouds defined as morph targets. I'm not sure how to correctly test all of this.