Set default language version through variable #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CMake reserved variable to specify default C++ language version,
so version can be adjust later by each target accordingly.
Recently I noticed that we can not change the C++ language version for targets
through
target_compile_features
. It turns out that setting language versionwith
add_definitions
is incompatible withtarget_compile_features
, asthe definition flags got propagated to actual command unconditionally.
This PR try to set the language version in a way that CMake awares.
see also: