This repository was archived by the owner on Mar 5, 2024. It is now read-only.
Load listeners on demand #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BTMorton
reviewed
Apr 6, 2018
src/directives/NgGrid.ts
Outdated
| private _enableResizeListeners(): void { | ||
| const resizeSubs = this._resize$.subscribe((e: MouseEvent) => this.resizeEventHandler(e)); | ||
|
|
||
| this._subscriptions.push(resizeSubs); |
There was a problem hiding this comment.
Should this be a standalone listener, rather than kept in the subscriptions method? Otherwise, it would be unsubscribed if the drag/resize config is not used
There was a problem hiding this comment.
Yes, you are right. I was trying to manage all listeners in the same way but since this listener must be always loaded I guess standalone listener is the best option. I will update it ASAP.
bruiztorres
commented
Apr 6, 2018
src/directives/NgGrid.ts
Outdated
| private _enableResizeListeners(): void { | ||
| const resizeSubs = this._resize$.subscribe((e: MouseEvent) => this.resizeEventHandler(e)); | ||
|
|
||
| this._subscriptions.push(resizeSubs); |
There was a problem hiding this comment.
About the testing, could you guide me in order to add some unit tests? I was unable to run them. I think I'm missing something.
# Conflicts: # src/directives/NgGrid.ts
bruiztorres
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using your library in order to display some widgets within a dashboard. Since the dashboard in my app is just for displaying information (there is no way to edit the position and size of the widgets) it doesn't make sense to load some listeners that are not going to be fired.
AFAIK there is no "angular" way to attach/detach listeners conditionally (angular/angular#7626). It seems it won't be implemented in short time so I just implemented this solution as proposed in the thread.
I experienced an improvement in terms of performance so I guess it could be useful for others. @BTMorton I have tried to add some unit tests but I'm unable to run them locally. Am I missing something? Maybe you can give me a clue about that. Thanks in advance.
Please let me know your questions/concerns.