Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIShield AI Security Monitoring Solution Guardian updates #11833

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

udanashivm
Copy link
Contributor

Required items, please complete

Added new Analytics rules, parser and sample data
Change(s):
See guidance below
Reason for Change(s):

See guidance below
Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below
Testing Completed:

yes
Checked that the validations are passing and have addressed any issues that are present:

@udanashivm udanashivm requested review from a team as code owners February 19, 2025 06:29
@v-shukore v-shukore self-assigned this Feb 19, 2025
@v-shukore v-shukore added Parser Parser specialty review needed Analytic Rules labels Feb 19, 2025
@udanashivm
Copy link
Contributor Author

Hi @v-shukore,

The test Validate_SolutionParsersFunctions_HaveValidKql is failing due to missing columns, tables, or functions. We have already added sample data and a custom table, but the issue persists.

Could you help us identify what might be missing or misconfigured? Thanks!

@v-shukore
Copy link
Contributor

Hi @udanashivm, we will investigate the KQL validation failure and update you by 24th Feb 2025. Thanks!!

@udanashivm
Copy link
Contributor Author

Hi @v-shukore , Just checking in on the KQL validation failure. Were you able to investigate the issue?

@v-shukore
Copy link
Contributor

Hello, @udanashivm. According to our observations, KQL validation is failing because the columns you specified in the parser query do not match the sample data you added. So, please adjust the column names in the query to match those in the sample data. You referenced "Policy_Violated_ControlFeature_s" in your query, but the column name is "Policy_Violated_Control_Feature_s" in the sample data, so please update it. Thanks!!

@v-shukore
Copy link
Contributor

Hi @udanashivm, we are waiting for your updates. Please make the changes so we can proceed further. Thanks!!

@udanashivm
Copy link
Contributor Author

Hi @udanashivm, we are waiting for your updates. Please make the changes so we can proceed further. Thanks!!

@v-shukore ,I have updated the code. Please review the changes and let us know if there is anything else pending from our side.
Looking forward to your feedback! Thanks!

@v-shukore
Copy link
Contributor

@udanashivm udanashivm requested a review from a team as a code owner March 6, 2025 07:14
@udanashivm
Copy link
Contributor Author

Hi @udanashivm, Please package the solution using V3 tool https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md Also, include workbook metadata in this file. https://github.com/Azure/Azure-Sentinel/blob/master/Workbooks/WorkbooksMetadata.json. Thanks!!

Thank you, @v-shukore, for the review. I’ve updated the WorkbooksMetadata.json details, created the solution package, and verified it. Please review and let me know if anything else is needed. Thanks!

@udanashivm
Copy link
Contributor Author

The Data Connector validation is failing. Could you please check and let us know the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytic Rules Parser Parser specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants