-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSE NUX: fix the dimensions of the preview image #42675
Conversation
Caution: This PR affects files in the FSE Plugin on WordPress.com D43989-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
The replacement image for When I'm testing however using This is both on this PR and a clean master branch (and clean sandbox before sync) 🤷 Usually when I ask the question "Is it just me or...?" I get the answer: "Yes, it's just you." Hoping to get that answer here as well :) It should look like (created with a new site + account on Gutenboarding in prod) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me after sandboxing D43989-code!
Thanks @andrewserong I totally forgot that the build log shows us where to test. TIR (Today I Remembered) |
Changes proposed in this Pull Request
To boldly fix the dimensions of the preview image to match the others where many have gone before.
Testing instructions
Create a new account and site at
/new
and let yourself be swept away by the journey to the editor.When the NUX modal appears, check that the images are of the same dimension and the jump affect is reduced.
Reported in #41966 (review)