Exclude playwright-report from eslint #10506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
danielmx-dev
requested review from
a team and
frosso
and removed request for
a team
danielmx-dev
added
the
size: x-small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request
I found that when there's a playwright-report folder in my project, the
eslintcommand will hang (or it's excessively slow). I was able to verify this by runningDEBUG=eslint:cli-engine npm run lint:jsand checking what the last processed file was.Since those files are generated by playwright we should ignore them during the linting process.
Testing instructions
playwright-reportfolder with contents, follow the instructions attests/e2e/README.mdto setup the tests, then you can force a single test to fail and run it. For example: Change the pay for order final expect for another string then run:npm run test:e2e tests/e2e/specs/wcpay/shopper/shopper-pay-for-order.spec.ts. A failure should be shown and the playwright-report file should be generated.npm run lint:jsBefore: The execution hangs or is really slow.
Now: The command should finish successfully after a few seconds (for me it takes ~12s).
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge