Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: improve My Jetpack link styles #23007

Merged
merged 7 commits into from
Feb 22, 2022

Conversation

retrofox
Copy link
Contributor

My Jetpack: improve My Jetpack link styles

Fixes #23006

Changes proposed in this Pull Request:

  • My Jetpack: improve My Jetpack link styles

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to My Jetpack overview
  • Check the styles when hovering the links
Screen.Recording.2022-02-21.at.4.00.03.PM.mov

@retrofox retrofox added this to the My Jetpack Integration milestone Feb 21, 2022
@retrofox retrofox requested a review from a team February 21, 2022 19:01
@retrofox retrofox self-assigned this Feb 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@retrofox retrofox force-pushed the update/my-jetpack-tweak-links branch from f93ed29 to 7bc9483 Compare February 22, 2022 14:26
Copy link
Contributor

@renatoagds renatoagds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 22, 2022
@retrofox retrofox merged commit ccfc47b into master Feb 22, 2022
@retrofox retrofox deleted the update/my-jetpack-tweak-links branch February 22, 2022 15:08
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My Jetpack: tweak Add product link style
4 participants