-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the app's Dockerfile and comment it #2162
Conversation
To avoid this problem from coming up again in the future, it might be worthwhile to test this Docker setup on CI. Let me know if you'd be interested in that. |
@resolritter Sure. Can you help with adding the Docker build check on CI?. |
Alright, I'll try that. Moving to Draft in the meantime. |
15062d4
to
20cce18
Compare
@LucasXu0 I think it's ready, but please take into account the following. The CI to test At first I wanted to use caching to speed up the Rust compilation, but attempting that ended up significantly increasing the code's complexity - see https://github.com/resolritter/AppFlowy/blob/docker2/.github/workflows/docker_ci.yml (which is unfinished). That's why I'm submitting the PR without any caching whatsoever. If I manage to finish and refine the caching solution, I'll submit a follow-up PR. |
@resolritter Thanks, it looks good to me. However, the Docker-CI is taking a lot of time. I think we should create a new issue to track and optimize it. |
Description
While trying to run the app through Docker (following https://appflowy.gitbook.io/docs/essential-documentation/install-appflowy/installation-methods/installing-with-docker) I ran into the following issues:
The app is only compatible with Flutter 3.3.10, but the Flutter version is not pinned in the Docker image.
Solved by downloading the precise version according to https://docs.flutter.dev/get-started/install/linux#install-flutter-manually.
I needed to run
xhost local:docker
in my host prior to starting the app, otherwise an error will occur.Solved by running the aforementioned command and adding a note about it.
The entrypoint
["./appflowy_flutter"]
apparently is incorrectSolved by figuring out where the executable is located within the generated bundle with
find . -executable -type f
While going through those issues and solving them, I tinkered with the image and added some comments along the way.
Trying it out