Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA 0.106.x compatible #14

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Conversation

Lau-ie
Copy link
Contributor

@Lau-ie Lau-ie commented Feb 24, 2020

Added two lines of code to the main file:
setConfig(config) {
config = JSON.parse(JSON.stringify(config)); // This uses built-in functions, but may be slower than

Based on Thomas Loven's helpfull comment.

Confirmed working on my install

Copy link

@ner0tic ner0tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes 16 and fixes 17

@r-renato
Copy link

Hi, for me this working fine even if it introduces a rendering issues when the plugin is used in sequence with other card type.
Practically, while the other cards are rendered the flex-horseshoe-card not. To show all cards I must to refresh the page over and over again.

@HFsi
Copy link

HFsi commented Mar 16, 2020

Doesn't work on 0.106.6

@noodlemctwoodle
Copy link

Confirmed working on 106.6 with changes suggested by @Lau-ie.

@HFsi
Copy link

HFsi commented Mar 25, 2020

In which part of the code should I add those lines?

@noodlemctwoodle
Copy link

@HFsi

Steps to get working:

  1. Download flex-horseshoe-card.js from Lau-ei as they have already made the required changes

  2. Put flex-horseshoe-card.js in a a folder by itself and remove any other files such as *.js.gz

    image

  3. Reboot Home Assistant

  4. Use the updated docs that are on either Lau-ei GitHub fork or My GitHub fork

@riddik14
Copy link

riddik14 commented Apr 1, 2020

I have add this repo in hacs

https://github.com/Lau-ie/flex-horseshoe-card

I have reinstalled the plugin from hacs and it work now.

thank you Lau-ie

@HFsi
Copy link

HFsi commented Apr 4, 2020

Yep, it's working now!

@pkpio
Copy link

pkpio commented Aug 21, 2020

Wondering if this is going to be merged for release soon?

@AmoebeLabs AmoebeLabs merged commit b379058 into AmoebeLabs:master Sep 29, 2020
@AmoebeLabs
Copy link
Owner

Hi everyone!

I'm slowly recovering from almost a year of illness, so that's the reason I didn't respond for a long time.
I'm still running hass 0.98, so I also have to update that part of my domotica installation.

I will test new version first, and then release a new version for HACS!

@Lau-ie
Copy link
Contributor Author

Lau-ie commented Sep 30, 2020

Hi Amoebelabs!

Very glad to have you back too further develop this awesome card!

@AmoebeLabs
Copy link
Owner

Hi Amoebelabs!

Very glad to have you back too further develop this awesome card!

Thanx for your PR btw, it helped a lot of ppl while I was not able to do any work on this.

I have now deployed another hass container next to my old 0.98 container, and since I'm using MQTT for most of my sensors, I can rebuild the new hass next to the old hass.

A lot has changed I must say:

  • My themes don't work anymore
  • Some cards are deprecated
  • The horseshoe has a 0.110 incompatibility (icon size, fixed already locally)
  • My other still unreleased card doesn't work anymore...
  • The order of events for custom cards seems to have changed, sometimes the horseshoe and the new card are fully drawn after a data update in the new hass, where they are fully drawn when the view is selected in the old hass. Must look into that later.

So, enough to do.

I will post on the forum once I tested and made a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants