Add list-ports command to show the available serial ports.

AVee · Feb 11, 2025 · 30eca8b · 30eca8b
1 parent be132b1
commit 30eca8b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/cargo-espflash/src/main.rs b/cargo-espflash/src/main.rs
@@ -90,8 +90,8 @@ enum Commands {
     HoldInReset(ConnectArgs),
     /// List serial ports available for flashing.
     ///
-    /// Only lists ports of devices known to be used on development boards. Use -a to show all
-    /// available ports.
+    /// Only lists ports of devices known to be used on development boards. Use
+    /// -a to show all available ports.
     ListPorts(ListPortsArgs),
     /// Open the serial monitor without flashing the connected target device
     Monitor(MonitorArgs),

diff --git a/espflash/src/bin/espflash.rs b/espflash/src/bin/espflash.rs
@@ -65,8 +65,8 @@ enum Commands {
     HoldInReset(ConnectArgs),
     /// List serial ports available for flashing.
     ///
-    /// Only lists ports of devices known to be used on development boards. Use -a to show all
-    /// available ports.
+    /// Only lists ports of devices known to be used on development boards. Use
+    /// -a to show all available ports.
     ListPorts(ListPortsArgs),
     /// Open the serial monitor without flashing the connected target device
     Monitor(MonitorArgs),

diff --git a/espflash/src/cli/mod.rs b/espflash/src/cli/mod.rs
@@ -392,7 +392,7 @@ pub fn checksum_md5(args: &ChecksumMd5Args, config: &Config) -> Result<()> {
 pub fn list_ports(args: &ListPortsArgs, config: &Config) -> Result<()> {
     let mut ports: Vec<SerialPortInfo> = serial::detect_usb_serial_ports(true)?
         .into_iter()
-        .filter(|p| args.all_ports || serial::known_ports_filter(&p, config))
+        .filter(|p| args.all_ports || serial::known_ports_filter(p, config))
         .collect();
     if ports.is_empty() {
         if !args.name_only {