Set computation dtype for PP weights #1350
Open
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We saw extra memory usage where it was hard to fit PP=21 TP=4 for llama405B with fsdp_ag_once which is surprising - memory usage should be dominated by AG the weights + gradients over FSDP which should be roughly 405B / (21 *4) * 4 = 20GB, but instead were OOMING but a little bit over 32GB on trillium. We had a f32 copy of the fsdp-gathered grads.
Notice 1 Once all tests pass, the "pull ready" label will automatically be assigned. This label is used
for administrative purposes. Please do not add it manually.
Notice 2 For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Ran on default 1B model on my v4-devbox with ici_pipeline=2, and pipeline_fsdp_ag_once=[True,False]
Checklist
Before submitting this PR, please make sure (put X in square brackets):