Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: use sync.Pool for reuse decoders in topic #1635

Open
rekby opened this issue Feb 5, 2025 · 2 comments
Open

dev: use sync.Pool for reuse decoders in topic #1635

rekby opened this issue Feb 5, 2025 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers topic issue for topic service

Comments

@rekby
Copy link
Member

rekby commented Feb 5, 2025

ydb-go-sdk/internal/topic/topicreadercommon/decoders.go

Line 13 in 273a3f9

type DecoderMap struct {

similar to writes pool:

ydb-go-sdk/internal/topic/topicwriterinternal/encoders.go

Line 26 in 273a3f9

type encoderPool struct {

@rekby rekby added enhancement New feature or request good first issue Good for newcomers topic issue for topic service labels Feb 5, 2025
@dlc-01
Copy link
Contributor

dlc-01 commented Feb 14, 2025

i take this

@rekby
Copy link
Member Author

rekby commented Feb 17, 2025

@dlc-01 great, thanks.

@dlc-01 dlc-01 mentioned this issue Feb 17, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers topic issue for topic service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rekby @dlc-01