Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate moving retries & api rate limits to tower #1704

Open
insipx opened this issue Mar 4, 2025 · 0 comments
Open

Investigate moving retries & api rate limits to tower #1704

insipx opened this issue Mar 4, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@insipx
Copy link
Contributor

insipx commented Mar 4, 2025

tower::retry::Retry exists and reqwest recently announced a more modular approach that would make more use of tower primitives like Retry. tonic also uses tower for its http implementation. In light of that information, we could probably share the rate limiting and retry implementation in libxmtp and remove code in common/retry.rs for retries/ratelimiting once these strategies are implemented in reqwest.

We still keep all the same macro structure we're using, but just lean on the tower-specific implementation of retry strategies/backoff/rate limits

@insipx insipx added the enhancement New feature or request label Mar 4, 2025
@insipx insipx added this to libxmtp Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant