Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Frontend] Fix validation of logprobs in ChatCompletionRequest #14352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schoennenbeck
Copy link
Contributor

@schoennenbeck schoennenbeck commented Mar 6, 2025

This fixes the validation of logprobs and top_logprobs for ChatCompletionRequest so that the class accepts its own default values.

FIX #14351

Signed-off-by: Sebastian Schönnenbeck <[email protected]>
Copy link

github-actions bot commented Mar 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Mar 6, 2025
@schoennenbeck schoennenbeck changed the title [Bugfix] Fix validation of logprobs in ChatCompletionRequest [Bugfix][Frontend] Fix validation of logprobs in ChatCompletionRequest Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ChatCompletionRequest rejects its own defaults
1 participant