Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make router a python package #17

Closed
gaocegege opened this issue Jan 24, 2025 · 4 comments · Fixed by #20
Closed

chore: Make router a python package #17

gaocegege opened this issue Jan 24, 2025 · 4 comments · Fixed by #20

Comments

@gaocegege
Copy link
Collaborator

Making the router a Python package offers several benefits:

  • The package can be installed with pip, simplifying dependency management and deployment.
  • Tests can be run more easily, and the package can be integrated into CI/CD pipelines for automated testing.
  • The package can be versioned, allowing for controlled updates and backward compatibility.

Besides, we should include some basic end-to-end (e2e) tests as part of the continuous integration (CI) pipeline.

@gaocegege
Copy link
Collaborator Author

Hey, I saw the roadmap mentions a "more performant router using non-Python languages." If we plan to tackle that soon, maybe we could explore rewriting the router in another language for a performance boost and ignore this. Just a thought.

@ApostaC
Copy link
Collaborator

ApostaC commented Jan 24, 2025

Hey @gaocegege , making it a python package sounds great to me!

We are right now working on end-to-end tests and CI pipeline. And it should be available soon. Thanks for pointing that out!

@gaocegege
Copy link
Collaborator Author

Thanks for the prompt response.

Should we turn it into a Python package now, or wait until the CI setup is ready? It may impact the CI implementation.

@ApostaC
Copy link
Collaborator

ApostaC commented Jan 24, 2025

It would be great if we could turn it into a python package now. (otherwise we need to adjust the CI again IIUC?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants