Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when invalid arguments are provided in the recipe for a modifier #1226

Open
dsikka opened this issue Mar 5, 2025 · 0 comments
Open
Labels
bug Something isn't working good first issue A good first issue for users wanting to contribute

Comments

@dsikka
Copy link
Collaborator

dsikka commented Mar 5, 2025

Describe the bug

  • You can provide extra irrelevant arguments when specifying a modifier and no error is thrown
  • This can mask issues for arguments that may no longer be supported or if they are provided incorrectly

E.g:

quant_stage:
    quant_modifiers:
        QuantizationModifier:
            dampen: 0.1
            ignore: ["lm_head"]
            config_groups:
                group_0:
                    weights:
                        num_bits: 8
                        type: "float"
                        symmetric: true
                        strategy: "tensor"
                        observer: "mse"
                    targets: ["Linear"]
  • The recipe below specifies dampen for the QuantizationModifier, however, this is not a valid argument and no error is thrown

Expected behavior

  • Validate recipe arguments are valid for the modifiers being specified
@dsikka dsikka added bug Something isn't working good first issue A good first issue for users wanting to contribute labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue A good first issue for users wanting to contribute
Projects
None yet
Development

No branches or pull requests

1 participant