Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when faulty recipes are provided during oneshot #1225

Open
dsikka opened this issue Mar 5, 2025 · 0 comments
Open

Fail when faulty recipes are provided during oneshot #1225

dsikka opened this issue Mar 5, 2025 · 0 comments
Labels
bug Something isn't working good first issue A good first issue for users wanting to contribute

Comments

@dsikka
Copy link
Collaborator

dsikka commented Mar 5, 2025

Describe the bug

  • Invalid recipes should throw an error

  • Currently, the following recipe is accepted as a valid recipe, however, the group_0 key should be under config_groups

quant_stage:
  quant_modifiers:
    GPTQModifier:
      ignore: ["lm_head"]
      group_0:
        weights:
          num_bits: 4
          type: "int"
          symmetric: true
          strategy: "group"
          group_size: 128
          actorder: "group"
          observer: "mse"
        targets: ["Linear"]

Expected behavior

  • Throw a clear error letting the user know their provided recipe is invalid
  • Indicate the issue in the provided recipe
@dsikka dsikka added bug Something isn't working good first issue A good first issue for users wanting to contribute labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue A good first issue for users wanting to contribute
Projects
None yet
Development

No branches or pull requests

1 participant