[PowerShell + CMD] fzf (Windows) does not work on Hyper

[yoav-lavi]

• OS version and name: Microsoft Windows 10 Enterprise Build 15063
• Hyper.app version: 2.1.1 (canary)
• The issue is reproducible in vanilla Hyper.app: Using a theme plugin

Issue

When using the fzf command on both PowerShell and CMD, Hyper returns character set not supported.
This does not reproduce in a normal PowerShell or CMD window.
fzf repo

[peterdanis]

Check junegunn/fzf#963 (comment). There is a Hyper specific solution.

[yoav-lavi]

The solution specified works, although it may be beneficial for the Windows Hyper version to not set TERM so it (and other utilities that would run into this problem) will work out of the box.

See janlazo's comment:

xterm-256color is hardcoded in app/session.js

    const baseEnv = Object.assign({}, process.env, {
           LANG: app.getLocale().replace('-', '_') + '.UTF-8',
           TERM: 'xterm-256color',
           TERM_PROGRAM: productName,
           TERM_PROGRAM_VERSION: version
     }, envFromConfig);

Hyper should not set TERM in Windows and let the shells handle this, such as sh.exe or bash.exe for TERM=cygwin.

At the very least, maybe Hyper should suggest adding the configuration below on Windows in a comment in the preferences \ Upon outputting Character Set Not Supported.

Per janlazo's suggestion:

env: {
   TERM: '',     
},