-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(new sink): add AWS Simple Notification Service #18142
Comments
Hi @wochinge, thanks for suggesting the sink and adding details about the use case and alternative solutions. One question so far is- would you personally (or if you are proposing this new component for the benefit of a business, would that entity) be open to an informal agreement to support the sink going forward? i.e , if there are bugs or enhancements filed about this new component, being open to being tagged as the assignee/reviewer for those issues. Thanks! |
We would like to use this new sink as part of an essential production component in my company. As part of that we of course have an interest in having this component in vector as well as fixing any bugs within the component or doing improvements. Happy to help out the community and contribute back (+ it gives me a reason to learn Rust :-)). I can relatively confidently say that this holds true for the next year but everything beyond that would be just guessing. From the AWS ecosystem perspective I also think that maintaining the SNS sink makes in my opinion more sense than maintaining the SQS sink as that's the more versatile approach. |
Thanks for sharing that background info, and for being open to supporting it. There may be further follow up questions but for now we will take a little time to work through some internal processing of the new component request. Stay tuned ~ |
Good news- we're open to accepting this new component 🎉 Given the amount of overlap with the |
Great news! 🎉 Thanks, @neuronull! |
A note for the community
Use Cases
Attempted Solutions
Proposal
I've already added a draft PR with a suggested implementation. Since it's very similar to the AWS sink we can re-use almost all of the things from the SQS implementation (testing environment, a lot of code, documentation, etc.). In line with that I'd also keep documentation / configuration very similar to AWS SQS.
References
aws_sns
sink #18141Version
v0.31.0
The text was updated successfully, but these errors were encountered: