Incorrect TypeScript types for TwiML

[dkundel]

Issue Summary

Some of the TwiML methods are missing type signatures with optional attributes. For example twiml.play() supports passing in just a string an argument for the URL but the TypeScript types require to pass in attributes. For others this is working correctly because they have multiple function signatures (for example twiml.say)

Steps to Reproduce

1. Open VSCode and create a Node.js project with the Twilio helper library installed
2. Add the code below into a new JavaScript file.
3. You should see an error highlighting the URL.

Code Snippet

// @ts-check
const twilio = require('twilio');
const twiml = new twilio.twiml.VoiceResponse();
twiml.play('https://demo.twilio.com/docs/classic.mp3');

Exception/Log

Type '"https://demo.twilio.com/docs/classic.mp3"' has no properties in common with type 'PlayAttributes'.ts(2559)

Technical details:

• twilio-node version: 3.39.5
• node version: 10.17.0

[childish-sambino]

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

[DCtheTall]

@childish-sambino I'd like to contribute a PR, but before I do any work I was wondering if you require contributors to sign a CLA?

[childish-sambino]

Nope, just check the box in the PR template and good to go.

…

On Mar 12, 2020, at 8:36 PM, Dylan Cutler ***@***.***> wrote:  @childish-sambino I'd like to contribute a PR, but before I do any work I was wondering if you require contributors to sign a CLA? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.