Smoke tests are too optimistic about scala-library

[susliko]

Commit of tree-sitter-scala you tested this on

2b6e547

A code sample showing the error

Smoke tests assume scala-library to be parsed without any errors.
Here is a list of errors after running ts parse .../scala/src/library/**/*.scala --quiet --stat locally:

scala/src/library/scala/collection/ArrayOps.scala                             5 ms    (ERROR [474, 12] - [474, 18])
scala/src/library/scala/collection/convert/StreamExtensions.scala             1 ms    (ERROR [42, 52] - [42, 67])
scala/src/library/scala/collection/generic/IsIterableOnce.scala               0 ms    (ERROR [55, 2] - [56, 4])
scala/src/library/scala/collection/generic/IsIterable.scala                   0 ms    (ERROR [132, 2] - [133, 4])
scala/src/library/scala/collection/generic/IsMap.scala                        0 ms    (ERROR [56, 2] - [60, 4])
scala/src/library/scala/collection/generic/IsSeq.scala                        0 ms    (ERROR [50, 120] - [51, 60])
scala/src/library/scala/collection/immutable/Map.scala                        3 ms    (ERROR [270, 11] - [270, 14])
scala/src/library/scala/collection/immutable/RedBlackTree.scala               5 ms    (ERROR [997, 16] - [997, 22])
scala/src/library/scala/collection/immutable/Vector.scala                     11 ms   (ERROR [1161, 23] - [1161, 36])
scala/src/library/scala/collection/IndexedSeq.scala                           0 ms    (ERROR [119, 53] - [119, 63])
scala/src/library/scala/collection/JavaConverters.scala                       0 ms    (ERROR [306, 25] - [306, 26])
scala/src/library/scala/collection/mutable/AnyRefMap.scala                    2 ms    (ERROR [416, 9] - [416, 11])
scala/src/library/scala/collection/mutable/ArrayDeque.scala                   2 ms    (MISSING "}" [91, 9] - [91, 9])
scala/src/library/scala/collection/mutable/Buffer.scala                       0 ms    (ERROR [195, 9] - [195, 12])
scala/src/library/scala/collection/mutable/CheckedIndexedSeqView.scala        0 ms    (ERROR [42, 87] - [42, 90])
scala/src/library/scala/collection/mutable/CollisionProofHashMap.scala        3 ms    (ERROR [324, 16] - [324, 27])
scala/src/library/scala/collection/mutable/ListBuffer.scala                   1 ms    (ERROR [16, 35] - [16, 38])
scala/src/library/scala/collection/mutable/LongMap.scala                      2 ms    (ERROR [429, 9] - [429, 11])
scala/src/library/scala/collection/mutable/MutationTracker.scala              0 ms    (ERROR [68, 76] - [68, 79])
scala/src/library/scala/collection/mutable/RedBlackTree.scala                 2 ms    (ERROR [488, 65] - [488, 75])
scala/src/library/scala/collection/Seq.scala                                  2 ms    (ERROR [1013, 53] - [1013, 63])
scala/src/library/scala/collection/StrictOptimizedIterableOps.scala           0 ms    (ERROR [32, 9] - [32, 12])
scala/src/library/scala/collection/StringOps.scala                            3 ms    (ERROR [1020, 9] - [1020, 14])
scala/src/library/scala/collection/View.scala                                 1 ms    (ERROR [107, 33] - [107, 34])
scala/src/library/scala/concurrent/DelayedLazyVal.scala                       0 ms    (ERROR [27, 45] - [27, 49])
scala/src/library/scala/runtime/ScalaRunTime.scala                            1 ms    (ERROR [36, 58] - [36, 74])
scala/src/library/scala/runtime/Tuple2Zipped.scala                            0 ms    (ERROR [124, 18] - [124, 30])
scala/src/library/scala/runtime/Tuple3Zipped.scala                            0 ms    (ERROR [133, 18] - [133, 30])
scala/src/library/scala/sys/process/ProcessBuilderImpl.scala                  1 ms    (ERROR [33, 76] - [33, 79])
scala/src/library/scala/sys/process/ProcessImpl.scala                         1 ms    (ERROR [194, 46] - [194, 52])
scala/src/library/scala/util/control/Exception.scala                          0 ms    (ERROR [194, 44] - [194, 48])
scala/src/library/scala/util/hashing/MurmurHash3.scala                        1 ms    (ERROR [100, 9] - [100, 15])

Show the error node

For example, ListBuffer.scala#L17 is subject to #206

  namespace_selectors [16, 34] - [16, 49]
    ERROR [16, 35] - [16, 38]
    identifier [16, 39] - [16, 43]
    identifier [16, 45] - [16, 48]

[eed3si9n]

That's odd. I think the smoke test parses the whatever the success % that was printed out. Is it rounding up some numbers?

[susliko]

I see that
npm exec -c 'tree-sitter parse /path/to/scala/src/library/**/*.scala --quiet --stat --time'
only parses direct children of library directory (117 files)
Dunno why

[eed3si9n]

ok so that's my bug in the smoke test then.

[eed3si9n]

Here's my PR for this #240