Fix if expression range #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfmengels It just occurred to me that maybe I should have made this PR for your backport-fixes-to-v7 branch instead of master. Let me know what you think. |
Keep on doing them on master. Cherry-picking them on v7 will rarely be difficult I think. |
jfmengels
pushed a commit
that referenced
this pull request
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #92.
As @jfmengels mentioned, this is indeed related to an earlier
let...inrange miscalculation. I think there might be more bugs like this (though I didn't find anymore right now) as it's caused byNode.parserwhich uses the current parser position as the end position of a range rather than using the end position of the child expression. For many cases, the current parser position and the end position of the expression are the same. But inlet,case, andifexpressions, this isn't true.