-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to writeType appear to be unreleased #117
Comments
Hi @ceddlyburge The version in I tried backporting and there seem to be some conflicts. @MartinSStewart could you take a look at that? I'm not familiar with it and I don't know if the tests can be relied on (enough) |
Hi Jeroen that makes sense, and that change isn't on the v7 branch. Is there any chance of making that change and doing a release? It's a trivial change, but I would be happy to create a PR if you would like. Also, thanks for all your general Elm work :) |
I haven't quite understood what the issue is yet so if you want to go ahead and make a PR for one of us to review that's fine by me! |
No worries #118 should be with you now .... |
Released in version |
Boom! Thanks both, thats amazingly speedy and helpful :) |
The definition of the writeType function that I have on my computer is different to the one in this repo (below)
elm-syntax/src/Elm/Writer.elm
Line 281 in 0fa8741
The version I have is missing the
indent 4
line, which was introduced 10 months ago to fix #30I am using version 7.2.1
I have just deleted elm-stuff and the global elm cache and re run, and I still don't have this version of the code.
I notice that the version in elm.json is still 7.1.3, so maybe this is causing the confusion?
elm-syntax/elm.json
Line 6 in 0fa8741
The text was updated successfully, but these errors were encountered: