Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to writeType appear to be unreleased #117

Closed
ceddlyburge opened this issue Mar 25, 2021 · 6 comments
Closed

Changes to writeType appear to be unreleased #117

ceddlyburge opened this issue Mar 25, 2021 · 6 comments

Comments

@ceddlyburge
Copy link
Contributor

The definition of the writeType function that I have on my computer is different to the one in this repo (below)

indent 4

The version I have is missing the indent 4 line, which was introduced 10 months ago to fix #30

I am using version 7.2.1

I have just deleted elm-stuff and the global elm cache and re run, and I still don't have this version of the code.

I notice that the version in elm.json is still 7.1.3, so maybe this is causing the confusion?

"version": "7.1.3",

@jfmengels
Copy link
Collaborator

Hi @ceddlyburge

The version in master has breaking changes, and we're not ready to release (not even close, since we'd like to batch a lot of breaking changes if possible). What you want to look for is the v7 branch, as that is what is still getting released.

I tried backporting and there seem to be some conflicts. @MartinSStewart could you take a look at that? I'm not familiar with it and I don't know if the tests can be relied on (enough)

@ceddlyburge
Copy link
Contributor Author

Hi Jeroen that makes sense, and that change isn't on the v7 branch.

Is there any chance of making that change and doing a release? It's a trivial change, but I would be happy to create a PR if you would like.

Also, thanks for all your general Elm work :)

@MartinSStewart
Copy link
Collaborator

I haven't quite understood what the issue is yet so if you want to go ahead and make a PR for one of us to review that's fine by me!

@ceddlyburge
Copy link
Contributor Author

No worries #118 should be with you now ....

@jfmengels
Copy link
Collaborator

Released in version 7.2.2!

@ceddlyburge
Copy link
Contributor Author

Boom!

Thanks both, thats amazingly speedy and helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants