-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow drawing from the Laplace approximation and Pathfinder without evaluating log_p #3215
Labels
Comments
I'm OK with providing this option. Some notes:
|
|
Also adding Pathfinder for this to not evaluate |
#3249 fixed this for Pathfinder, but I guess Laplace part is not yet done |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary:
Currently, when drawing from the Laplace approximation, log_p and log_q are always evaluated for each draw. log_p and log_q are useful for diagnosing the accuracy of the Laplace approximation, but there are cases where we trust that the normal approximation at the mode is sufficient and then we would not need log_p and log_q, and evaluation of log_p for all draws usually takes much more time than finding the mode, computing hessian, and drawing from the normal take. So it would be useful to make it optional and output just 0 or NA to the csv when the user so requests.
The relevant part in Stan services is
stan/src/stan/services/optimize/laplace_sample.hpp
Line 110 in 3c2b7ba
Naturally the change would need to make also in stan/arguments, cmdstan, and other interfaces, too
Current Version:
v2.32.2
The text was updated successfully, but these errors were encountered: