Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package @smithy/middleware-endpoint missing dep on @smithy/shared-ini-file-loader #1019

Closed
RichiCoder1 opened this issue Oct 10, 2023 · 6 comments · Fixed by #1027
Closed

Comments

@RichiCoder1
Copy link

The package @smithy/middleware-endpoint is missing an explicit dependency on @smithy/shared-ini-file-loader. It referenced here. This breaks stricter package managers which requires all dependencies be explicitly listed.

@bczerwonka-cksource
Copy link

Yes, I can confirm that. I have the same problem.

@rajivmothilal
Copy link

I too can confirm that. Same issue when I upgraded my dependencies.

@Mezzle
Copy link

Mezzle commented Oct 12, 2023

Further to this - that package doesn't actually export CONFIG_PREFIX_SEPARATOR - therefore breaking the use of Eventbridge

@trivikr
Copy link
Contributor

trivikr commented Oct 12, 2023

Fix is posted at #1027

A workaround is to add overrides in package.json to use previous version as follows:

{
  "overrides": {
    "@smithy/middleware-endpoint": "2.0.11"
  }
}

@trivikr
Copy link
Contributor

trivikr commented Oct 12, 2023

The issue was fixed in @smithy/[email protected]

@Mezzle @rajivmothilal @bczerwonka-cksource @RichiCoder1
Can you confirm if the issue is fixed for you?

@bczerwonka-cksource
Copy link

It looks like I can confirm that it works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants