Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.sc files should be treated as scala files #443

Closed
benwaffle opened this issue Dec 7, 2018 · 8 comments · Fixed by #644
Closed

.sc files should be treated as scala files #443

benwaffle opened this issue Dec 7, 2018 · 8 comments · Fixed by #644

Comments

@benwaffle
Copy link
Contributor

benwaffle commented Dec 7, 2018

These are either scala worksheet files or ammonite script files

Scala worksheets are normal Scala files, except that theythey end in .sc instead of .scala.

(and when I say treated I specifically mean syntax highlighted; not sure if anything else changes based on the file type)

@sharkdp
Copy link
Owner

sharkdp commented Dec 7, 2018

Thank you for your feedback.

There are two (non-exclusive) options:

@benwaffle
Copy link
Contributor Author

Thanks! sublimehq/Packages#1801

Do you want to close this PR, or wait for the sublime PR to be merged and for bat to update its sublime files?

@sharkdp
Copy link
Owner

sharkdp commented Dec 7, 2018

I will automatically keep up to date with sublimehq/Packages, so I think we can close this. Thank you!

@sharkdp sharkdp closed this as completed Dec 7, 2018
@benwaffle
Copy link
Contributor Author

sublimehq/Packages#1801 has been merged, so the Packages submodule needs to be updated, right?

@sharkdp
Copy link
Owner

sharkdp commented Jan 16, 2019

@benwaffle Yes, thank you for the reminder. I will do that prior to the next release of bat

@benwaffle
Copy link
Contributor Author

Could you please update the submodule?

@sharkdp
Copy link
Owner

sharkdp commented Aug 31, 2019

Unfortunately, this is blocked by #499. Maybe I should reopen it after all.

@sharkdp
Copy link
Owner

sharkdp commented Mar 22, 2020

This has been fixed in bat 0.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants