Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate build/webpack to use compiled plugins #467

Open
setchy opened this issue Dec 22, 2024 · 2 comments · May be fixed by #718
Open

migrate build/webpack to use compiled plugins #467

setchy opened this issue Dec 22, 2024 · 2 comments · May be fixed by #718
Labels
enhancement New feature or enhancement to existing functionality help wanted Extra attention is needed priority:high Items of high importance. Applicable to all users or use-cases

Comments

@setchy
Copy link
Owner

setchy commented Dec 22, 2024

📝 Provide a description of the new feature

Atlassian Design System components have replaced their use of emotion to compiled css-in-js.

Migrating to this is required in order to adopt the latest major versions of @atlaskit components (see all open renovate PRs with breaking checks)

➕ Additional Information

@setchy setchy added enhancement New feature or enhancement to existing functionality help wanted Extra attention is needed priority:high Items of high importance. Applicable to all users or use-cases labels Dec 22, 2024
@setchy setchy changed the title migrate build/webpack to use compiled migrate build/webpack to use compiled plugins Dec 22, 2024
@danieldelcore
Copy link

Hey @setchy 👋

Are you having any trouble getting this to work? If so, is there a PR or something I can have a look at 🙏

Cheers!

@setchy setchy linked a pull request Mar 9, 2025 that will close this issue
@setchy
Copy link
Owner Author

setchy commented Mar 9, 2025

Hey @danieldelcore - thanks for reaching out.

I've had several attempts over the past ~3-4 months at migrating, but so far I haven't managed to get a working configuration.

This is the most recent attempt: #718

When I update any of the out-of-date atlaskit packages the app tends to fail rendering as well as the jest test suite doesn't run (eg: @atlaskit/[email protected]). Actually, it seems like scripts such as pnpm watch:render hangs

I'd appreciate any assistance/tips 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality help wanted Extra attention is needed priority:high Items of high importance. Applicable to all users or use-cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants