Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message template is not updated while property renaming #103

Open
1 task done
mishamyte opened this issue Apr 1, 2022 · 4 comments
Open
1 task done

Message template is not updated while property renaming #103

mishamyte opened this issue Apr 1, 2022 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mishamyte
Copy link
Member

Which version of Serilog.Sinks.Grafana.Loki are you using?

v8.0.0-beta.0

Which version of .NET are you using?

net6.0

Describe the bug

New feature, that adds a level as a property fixes the collision with naming, but the MessageTemplate is not updated and rendered output is broken

To Reproduce

_logger.LogInformation("Hero's {level}", 42);

Expected behavior

Templated should be consistent with renamed properties names

Log/SelfLog output or exception with stacktrace

No response

Application or code sample, which could be used to reproduce a bug

No response

Additional context

image

I have read the documentation

@mishamyte mishamyte added the bug Something isn't working label Apr 1, 2022
@mishamyte mishamyte added this to the v8.0.0 milestone Apr 1, 2022
@mishamyte mishamyte self-assigned this Apr 1, 2022
@rogeralsing
Copy link

Many thanks for this fix, we are now using this lib again and it works perfectly! <3

@mishamyte
Copy link
Member Author

@rogeralsing seems like you are talking about another issue, aren't you?

@rogeralsing
Copy link

My bad. this one: #94

@mishamyte
Copy link
Member Author

After research I've found that it is not possible to fix it easily. So I think we will keep it for the future releases

@mishamyte mishamyte modified the milestones: v8.0.0, Backlog Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants