Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Upgrade Guide doesn't put config back #3577

Closed
mkasberg opened this issue Mar 2, 2025 · 2 comments
Closed

docs: Upgrade Guide doesn't put config back #3577

mkasberg opened this issue Mar 2, 2025 · 2 comments
Assignees

Comments

@mkasberg
Copy link

mkasberg commented Mar 2, 2025

On which page do you see this issue?

https://daisyui.com/docs/upgrade/

Describe the issue

In step 1, part 1 of the upgrade guide, we remove some config v4 DiasyUI config.

module.exports = {
   content: ['./your-files/**/*.{html,js}'],
   // other stuff...
-  daisyui: {
-    themes: ['light', 'dark', 'cupcake'],
-  },
- plugins: [require("daisyui")],
}

Then, in step 2, part 3 (side note - just noticed the steps are misnumbered), we add the DaisyUI plugin to our css file.

@import "tailwindcss";
+ @plugin "daisyui";

At the end of the upgrade guide, we've deleted the themes: ['light', ... config and never put it back. I think the easiest improvement would be to include the themes from the first step as an example of config, with a link to the config docs for more detailed instructions.

@import "tailwindcss";
+ @plugin "daisyui" {
+   themes: light, dark, cupcake;
+ }

Thoughts? I could open a quick PR to improve this if that would be helpful.

What browsers are you seeing the problem on?

No response

Copy link

github-actions bot commented Mar 2, 2025

Thank you @mkasberg for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

@saadeghi saadeghi self-assigned this Mar 2, 2025
@saadeghi
Copy link
Owner

saadeghi commented Mar 3, 2025

Fixed. Thanks!

@saadeghi saadeghi closed this as completed Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants