Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links in deprecated notes have poor contrast #98341

Closed
jplatte opened this issue Jun 21, 2022 · 4 comments · Fixed by #134861
Closed

Links in deprecated notes have poor contrast #98341

jplatte opened this issue Jun 21, 2022 · 4 comments · Fixed by #134861
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. L-deprecated Lint: deprecated T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jplatte
Copy link
Contributor

jplatte commented Jun 21, 2022 •
edited
Loading

I tried documenting this code:

#[deprecated = "Replaced by [`Client::login_token`](#method.login_token)"]
pub async fn login_with_token(
    // ...

I expected to see this happen: cargo doc generating a beautiful doc page

Instead, this happened:

Screenshot_2022-06-21_154838

Meta

rustc --version --verbose:

rustc 1.63.0-nightly (cacc75c82 2022-06-16)
binary: rustc
commit-hash: cacc75c82ebe15cf63d31034fcf7f1016cddf0e2
commit-date: 2022-06-16
host: x86_64-unknown-linux-gnu
release: 1.63.0-nightly
LLVM version: 14.0.5

@rustbot labels: +T-rustdoc +A-rustdoc-ui
@jplatte jplatte added the C-bug Category: This is a bug. label Jun 21, 2022
@jplatte jplatte mentioned this issue Jun 21, 2022
Closed
@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jun 21, 2022
@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 26, 2022
Closed
@fmease fmease added the L-deprecated Lint: deprecated label Dec 28, 2024
@fmease
Copy link
Member

fmease commented Dec 28, 2024

Triage: Rendering today:

Image

@fmease
Copy link
Member

fmease commented Dec 28, 2024

I think we can close this issue though I wonder if we want to have a GUI test for this if we don't have one already

@GuillaumeGomez
Copy link
Member

I'll add one.

@jplatte
Copy link
Contributor Author

jplatte commented Dec 28, 2024

Contrast is okay-ish now but I think it would look considerably better witht the same color as text, only underlined. May be personal taste. Extra weird though that ayu has the underline in a different color from the link text.

@GuillaumeGomez GuillaumeGomez mentioned this issue Dec 28, 2024
Merged
Noratrieb added a commit to Noratrieb/rust that referenced this issue Dec 31, 2024
@Noratrieb
Rollup merge of rust-lang#134861 - GuillaumeGomez:item-info-colors, r…
7870003 
…=fmease

Add GUI test for item info elements color

Fixes rust-lang#98341.

r? `@fmease`
@bors bors closed this as completed in 63d5b72 Jan 1, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 1, 2025
@rust-timer
Unrolled build for rust-lang#134861
3a1e040 
Rollup merge of rust-lang#134861 - GuillaumeGomez:item-info-colors, r=fmease

Add GUI test for item info elements color

Fixes rust-lang#98341.

r? ``@fmease``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. L-deprecated Lint: deprecated T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GUI test for item info elements color GuillaumeGomez/rust
4 participants
@jplatte @GuillaumeGomez @fmease @rustbot