Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference rules changed on 1.10 nightly #33657

Closed
crumblingstatue opened this issue May 15, 2016 · 7 comments
Closed

Inference rules changed on 1.10 nightly #33657

crumblingstatue opened this issue May 15, 2016 · 7 comments

Comments

@crumblingstatue
Copy link
Contributor

crumblingstatue commented May 15, 2016

struct Foo;
struct Bar;

fn foo_ref_to_bar_ptr(foo: &Foo) -> *const Bar {
    foo as *const _ as _
}

This builds on 1.10 nightly, but inference fails on beta and stable.

If this is a desired change, it should probably be documented, and regression tests added.
If not, it should be made into an error.

@arielb1
Copy link
Contributor

arielb1 commented May 16, 2016

This is a desired change, and which I am quite sure has a regression test.

@nagisa nagisa added the relnotes Marks issues that should be documented in the release notes of the next release. label May 17, 2016
@nagisa
Copy link
Member

nagisa commented May 17, 2016

Seems like something we want in relnotes, thus, in order to be on the safe side, adding the label.

@nagisa
Copy link
Member

nagisa commented May 17, 2016

@arielb1 do you know which PR made the change?

@arielb1
Copy link
Contributor

arielb1 commented May 17, 2016

Found it - #32258

@nagisa
Copy link
Member

nagisa commented May 17, 2016

Thanks @arielb1

@nagisa nagisa removed the relnotes Marks issues that should be documented in the release notes of the next release. label May 17, 2016
@brson brson added the regression-from-stable-to-stable Performance or correctness regression from one stable version to another. label Jun 30, 2016
@crumblingstatue
Copy link
Contributor Author

@brson Is this really a regression? As far as I understand, it strictly allows more code to compile, and doesn't break old code.

The reason I opened this issue is because this seemed like an undocumented change.

@arielb1
Copy link
Contributor

arielb1 commented Jul 3, 2016

not a regression.

@arielb1 arielb1 removed the regression-from-stable-to-stable Performance or correctness regression from one stable version to another. label Jul 3, 2016
@arielb1 arielb1 closed this as completed Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants