Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc search: setting HTMLDialogElement.open directly is not reccomended #138316

Open
lolbinarycat opened this issue Mar 10, 2025 · 4 comments
Open

rustdoc search: setting HTMLDialogElement.open directly is not reccomended #138316

lolbinarycat opened this issue Mar 10, 2025 · 4 comments
Labels
A-rustdoc-search Area: Rustdoc's search feature needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Comments

@lolbinarycat
Copy link
Contributor

lolbinarycat commented Mar 10, 2025 •
edited
Loading

This is done quite a bit in main.js, but according to MDN this breaks stuff

cc @notriddle
@lolbinarycat lolbinarycat added the A-rustdoc-search Area: Rustdoc's search feature label Mar 10, 2025
@rustbot rustbot added T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 10, 2025
@notriddle
Copy link
Contributor

notriddle commented Mar 10, 2025 •
edited
Loading

Where? I've opened search.js and grepped for open and no matches were found. I didn't think we were using HTMLDialogElement anywhere.

@lolbinarycat
Copy link
Contributor Author

Oops, my bad, it's in main.js.

@notriddle
Copy link
Contributor

Isn't that HTMLDetailsElement?

@lolbinarycat
Copy link
Contributor Author

ohhh my bad, I hadn't considered there could be two unrelated subclasses of HTMLElement with an identically named property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-search Area: Rustdoc's search feature needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@notriddle @lolbinarycat @rustbot