Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"macabi" is not an "ABI" in the same sense as e.g. "gnueabihf" #133331

Open
workingjubilee opened this issue Nov 22, 2024 · 1 comment
Open

"macabi" is not an "ABI" in the same sense as e.g. "gnueabihf" #133331

workingjubilee opened this issue Nov 22, 2024 · 1 comment
Labels
A-targets Area: Concerning the implications of different compiler targets C-bug Category: This is a bug. O-ios Operating system: iOS O-macos Operating system: macOS T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@workingjubilee
Copy link
Member

I know it has the literal characters "abi" in it but it's not an "ABI" in the sense of "gnueabihf", the HF and SF targets use actually-different calling conventions. It should probably have been a target_env.

Same story with the Apple "sim" targets.
@workingjubilee workingjubilee added C-bug Category: This is a bug. O-ios Operating system: iOS O-macos Operating system: macOS labels Nov 22, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 22, 2024
@workingjubilee workingjubilee added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 22, 2024
@jieyouxu jieyouxu added A-targets Area: Concerning the implications of different compiler targets and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 22, 2024
@madsmtm
Copy link
Contributor

madsmtm commented Mar 1, 2025 •
edited
Loading

So, I actually went and made a whole branch that adds target_env = "macabi"/target_env = "sim", but just before submitting that as a PR, I re-read the RFC and tracking issue, and it seems that target_abi was originally added for the purpose of Apple's sim/macabi targets.

@nvzqz, do you recall the motivation for not just using target_env?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-targets Area: Concerning the implications of different compiler targets C-bug Category: This is a bug. O-ios Operating system: iOS O-macos Operating system: macOS T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@madsmtm @jieyouxu @workingjubilee @rustbot