Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-component-ld is installed into *-pc-windows-gnu{,llvm} sysroot even when it's disabled in config #131773

Closed
ognevny opened this issue Oct 16, 2024 · 3 comments
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@ognevny
Copy link
Contributor

ognevny commented Oct 16, 2024

the config enables these tools

tools = [
  "cargo",
  "clippy",
  "rustdoc",
  "rustfmt",
  "rust-analyzer-proc-macro-srv",
  "analysis",
  "src",
]

but wasm-component-ld is built anyway and (starting with 1.82.0) installed into target's sysroot even when there is such tool in $PATH available. lld = false is set explicitly

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 16, 2024
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Oct 16, 2024
@ognevny
Copy link
Contributor Author

ognevny commented Oct 16, 2024

update: I encountered it in msys2/MINGW-packages#22205

@jieyouxu
Copy link
Member

cc @onur-ozkan I think you worked on unifying llvm-tools logic, do you know if this is intentional?

@ognevny
Copy link
Contributor Author

ognevny commented Oct 16, 2024

turns out #130034 fixed it. thanks Alex!

@ognevny ognevny closed this as completed Oct 16, 2024
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

3 participants