rustc_private?

[smoelius]

Can a crate that uses rustc_private be built on docs.rs?

I have been trying to build this crate: https://docs.rs/crate/dylint_linting

My most recent attempt was to add the relevant rustc components manually from the build script, which didn't work.

Is what I am trying to do possible? If so, what is the "right" way to build a crate that uses rustc_private on docs.rs?

Thank you.

[jyn514]

Hmm. This is definitely not supported today, but it seems ok to run rustup component add rustc_private before building the docs. My only concern is that it seems like most builds will fail anyway because we always build with latest nightly and the API changes so frequently.

@smoelius can you talk a little more about how you were imagining this would work? "only the latest nightly" seems limiting; I guess we could support an arbitrary date but then it will be easy to overload the server just by publishing many crates with different rustc_private toolchains.

cc #506, #228

[smoelius1]

@smoelius can you talk a little more about how you were imagining this would work? "only the latest nightly" seems limiting

"Only the latest nightly" would work for my use case.

Strictly speaking, dylint_linting has always required a nightly compiler. The intent is that it build with every nightly since the one coinciding with it's initial release. Here, for example, is a case where dylint_linting had to adjust for a rustc API change.

dylint_linting has been building successfully on docs.rs because it consists largely of macros. It only started requiring rustc_private recently.

If the latest nightly was not possible, an arbitrary recent nightly chosen by docs.rs also seems workable.

In other words, if docs rs' policy was "we'll give you a nightly with rustc_private from within (say) the past six weeks, the rest is up to you," I could live with that.

(Apologies as I am traveling and don't have access to my normal @smoelius account. If you would prefer, I could reaffirm the above this coming Monday.)

[jyn514]

"Only the latest nightly" would work for my use case

Oh, perfect! that should be quite easy to do on our side then :)

Apologies as I am traveling and don't have access to my normal @smoelius account. If you would prefer, I could reaffirm the above this coming Monday.

No worries, you're perfectly fine :) I'm not worried about someone maliciously pretending to be you to tell us to implement a feature lol (not sure how that would even work).

Mentoring instructions: add a call to toolchain.install_component("rustc_private") around here, following rustfmt's example:

docs.rs/src/docbuilder/rustwide_builder.rs

Line 191 in e3e044b

if let Err(err) = self.toolchain.add_component(&self.workspace, "rustfmt") {