Add Motor Temperature to stateExt and Convert PWM to Float #3188
+207
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion with @randaz81 and @traversaro, we decided to add motor temperature data to
stateExt
, streamed as a vector of floats. To avoid increasing the message size, we also decided to convert the PWM data from a vector of doubles to a vector of floats.This pull request introduces several changes to the
RemoteControlBoard
and related components to support temperature data. The modifications affect data structures, methods, and interfaces to handle temperature readings properly.The PR consists of two commits:
float32
conversion inBottle
. Without this, reading from thestateExt
port results in the following error:Note
I also regenerated the
jointData.cpp
andjointData.h
to be compliant with the new thrift