Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Motor Temperature to stateExt and Convert PWM to Float #3188

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GiulioRomualdi
Copy link
Member

After a discussion with @randaz81 and @traversaro, we decided to add motor temperature data to stateExt, streamed as a vector of floats. To avoid increasing the message size, we also decided to convert the PWM data from a vector of doubles to a vector of floats.

This pull request introduces several changes to the RemoteControlBoard and related components to support temperature data. The modifications affect data structures, methods, and interfaces to handle temperature readings properly.

The PR consists of two commits:

  • e889527: Modifies the message to add temperature data and converts the PWM vector to float.
  • a435ecd: Adds support for float32 conversion in Bottle. Without this, reading from the stateExt port results in the following error:
    [ERROR]  |yarp.os.impl.BottleImpl| Reader failed, unrecognized object code 0
    

Note

I also regenerated the jointData.cpp and jointData.h to be compliant with the new thrift

GiulioRomualdi and others added 2 commits March 6, 2025 16:10
- Stream the motor temperature as float
- modify the PWM to be streamed as float
Copy link

update-docs bot commented Mar 6, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants