Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fetching changelog from bitbucket-server #8662

Closed
zeldigas opened this issue Feb 12, 2021 · 3 comments
Closed

Support fetching changelog from bitbucket-server #8662

zeldigas opened this issue Feb 12, 2021 · 3 comments
Labels
duplicate This issue is closed as a duplicate of another issue platform:bitbucket-server Bitbucket Data Center and Server platform status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@zeldigas
Copy link
Contributor

What would you like Renovate to be able to do?

Right now repositories stored in BitbucketServer are not processed during release-notes fetching, I got the following debug message in logs:

DEBUG: Fetching changelog: https://mybb.acme.com/projects/PRJ/repos/internal-repo/browse (3.2.0 -> 3.3.0) (repository=~jsmith/changelog-test)
DEBUG: Repository URL does not match any known github hosts - skipping changelog retrieval (repository=~jsmith/changelog-test)
       "manager": "maven",
       "depName": "com.acme.libs:my-lib",
       "sourceUrl": "https://mybb.acme.com/projects/PRJ/repos/internal-repo/browse"

In case of configured platform to bitbucket-server I'd like renovate to support going to repository by resolved url and fetch release notes from CHANGELOG.md if it's located in repo.

Did you already have any implementation ideas?

Looks like current code responsible for fetching changelog is full of if checks for platform - for github and gitlab. I think that adding one more if branch in all the places would increase entropy significantly. I think that better option would be to introduce some interface that can be implemented by various platforms.

I can try to work on this, but might need some help from renovate dev team in case of questions as code base for PR resolution is not that small + relies on concept of releases that some platforms do not have (bitbucket-server specifically) that would affect the way to identify the range of looked up items in changelog.md file.

@viceice
Copy link
Member

viceice commented Feb 12, 2021

I think we have an open issue for supporting other platform changelog fetching. That code needs a major refactoring before we can add new platforms for sure.

@viceice viceice added platform:bitbucket-server Bitbucket Data Center and Server platform type:feature Feature (new functionality) status:requirements Full requirements are not yet known, so implementation should not be started labels Feb 12, 2021
@HonkingGoose
Copy link
Collaborator

I think I found the issue that @viceice is talking about, and I think the current issue is a duplicate of the older issue.

Duplicate of #3903

@viceice
Copy link
Member

viceice commented Feb 12, 2021

Duplicate of #3903

@viceice viceice marked this as a duplicate of #3903 Feb 12, 2021
@viceice viceice closed this as completed Feb 12, 2021
@HonkingGoose HonkingGoose added the duplicate This issue is closed as a duplicate of another issue label Feb 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue is closed as a duplicate of another issue platform:bitbucket-server Bitbucket Data Center and Server platform status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

3 participants